feat(ENGDESK-27107): Upgrade WebRTC library to support React 18 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeividVeloso
force-pushed
the
upgrade-react
branch
from
7f717ea
to
52f8ca7
Compare
DeividVeloso
requested review from
a team,
ericaprieto,
lmao12,
jonathan-telnyx and
priscillasantana
jonathan-telnyx
approved these changes
Nov 16, 2023
lmao12
approved these changes
Nov 16, 2023
packages/react-client/package.json
Outdated
| @@ -20,6 +20,7 @@ | |||
| "build": "microbundle-crl --no-compress --format modern,cjs", | |||
| "start": "microbundle-crl watch --no-compress --format modern,cjs", | |||
| "prepare": "install-peers && run-s build", | |||
| "install-peers": "install-peers", | |||
There was a problem hiding this comment.
Do we need this? It seems like this would install the peerDependencies as devDependencies, according to the documentation: https://www.npmjs.com/package/install-peers
There was a problem hiding this comment.
it was already there as you can see on the line above.
|
|
||
| if (props?.onNotification) { | ||
| telnyxClient!.on('telnyx.notification', props.onNotification); | ||
| } | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
Do you need to add telnyxClient as a dependency or will this have client on initial render?
There was a problem hiding this comment.
thanks for cathing it, I added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 To Do
✋ Manual testing
packages/react-client🦊 Browser testing
Desktop