Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better bottomsheet #92

Merged
merged 2 commits into from
Dec 14, 2023
Merged

feat: better bottomsheet #92

merged 2 commits into from
Dec 14, 2023

Conversation

Jinho1011
Copy link
Member

BottomSheet을 개선했습니다

  1. useBottomSheet hooks로 BottomSheet를 선언적으로 사용할 수 있게 변경

BottomSheet를 사용할 때 마다 이 BottomSheet를 열고 닫기 위한 상태, 조건부 렌더링을 구현했었는데, 이 구현부를 useBottomSheet로 숨겼습니다.

const { BottomSheet: CommentSheet, toggleSheet } = useBottomSheet({});
  1. BackDrop 영역의 zindex를 수정하여 더 이상 백드롭 영역을 클릭했을 때 바탕의 요소가 클릭되지 않습니다.

@Jinho1011 Jinho1011 merged commit 6de4177 into dev Dec 14, 2023
1 check passed
@Jinho1011 Jinho1011 deleted the feat/better-bottomsheet branch December 14, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant