Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Load subtitles from the current .mkv file #8

Open
milichev opened this issue Nov 3, 2023 · 1 comment
Open

Enhancement: Load subtitles from the current .mkv file #8

milichev opened this issue Nov 3, 2023 · 1 comment

Comments

@milichev
Copy link
Contributor

milichev commented Nov 3, 2023

Current state

Currently, one needs to find subtitles via VLsub, and load, if any are found.

Problems

  1. The media file might already contain embedded subtitles, therefore it is not needed to find ones elsewhere.
  2. On top of that, the embedded subtitles might be uniquely prepared, synced, etc.
  3. When the current media file changes, the selected subtitles in the extension remain the same.

Proposed functionality

  1. When the current media file contains subtitles (f.x. a *.mkv file), the extension should load ones.
  2. When the media file changes, the extension has to select subtitles appropriately, either embedded ones or previously downloaded. The embedded subtitles have precedence. Apparently, the extension should listen to an event of file change.
@NemanSyed
Copy link

Agreed. I have many MKVs where the subtitles are embedded so the end user only has one file to manage without regard to how many languages. It would be immensely helpful if this tool could optionally search the currently selected embedded subtitles, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants