Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support signed URLs with Google Cloud Application Default Credentials (ADC) #120

Open
flokli opened this issue Apr 29, 2021 · 1 comment
Open

Support signed URLs with Google Cloud Application Default Credentials (ADC) #120

flokli opened this issue Apr 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@flokli
Copy link
Contributor

flokli commented Apr 29, 2021

When running nixery on a GCP instance with the default service account / in a cloud run function / GKE, nixery should still be able to emit signed URLs to GCS buckets. It currently has code only doing this if GOOGLE_APPLICATION_CREDENTIALS is set explicitly.
@tazjin tazjin added the enhancement New feature or request label Apr 29, 2021
@tazjin
Copy link
Owner

tazjin commented Apr 29, 2021

It should not do this without the feature being explicitly enabled, as the signBlob API unfortunately requires service account impersonation credentials. Useful to have though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flokli @tazjin