Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change android_binding to not take in the path as an arg #1380

Open
jkelleyrtp opened this issue Oct 3, 2024 · 1 comment
Open

Change android_binding to not take in the path as an arg #1380

jkelleyrtp opened this issue Oct 3, 2024 · 1 comment

Comments

@jkelleyrtp
Copy link

jkelleyrtp commented Oct 3, 2024

Is your feature request related to a problem? Please describe.

Right now the android_binding code is defined like so:

  ($domain:ident, $package:ident, $activity:ident, $setup:path, $main:ident, $tao:path) => {{
    use $tao::{platform::android::prelude::android_fn, platform::android::prelude::*};
    fn _____tao_store_package_name__() {
      PACKAGE.get_or_init(move || generate_package_name!($domain, $package));
    }

This forces you to pass in something like com_example as an arg. I think you can work around this by calling the binding methods manually, but it'd be much nicer to just set the com_example/wrytest manually in a static such that this binding can be hidden.

        tao::android_binding!(
            com_example,
            wrytest,
            WryActivity,
            wry::android_setup,
            _start_app,
            tao
        );
        wry::android_binding!(com_example, wrytest, wry);
@amrbashir
Copy link
Member

What would the ideal use case look like for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants