We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
The mechanism driving handleRequest on android has an unsafe impl Sync bound that allows it to be called from shouldInterceptRequest.
unsafe impl Sync
shouldInterceptRequest
However, this is wrong, since shouldInterceptRequest is not called from the main thread:
Note: This method is called on a thread other than the UI thread so clients should exercise caution when accessing private data or the view system.
https://developer.android.com/reference/android/webkit/WebViewClient#shouldInterceptRequest(android.webkit.WebView,%20android.webkit.WebResourceRequest)
This is causing dioxus to segfault, locks to fail, RC to double-drop, etc.
This function should instead use a channel to block until the response is ready from the main thread.
It's likely there are more functions being called from not-the-main-thread.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
The mechanism driving handleRequest on android has an
unsafe impl Sync
bound that allows it to be called fromshouldInterceptRequest
.However, this is wrong, since
shouldInterceptRequest
is not called from the main thread:https://developer.android.com/reference/android/webkit/WebViewClient#shouldInterceptRequest(android.webkit.WebView,%20android.webkit.WebResourceRequest)
This is causing dioxus to segfault, locks to fail, RC to double-drop, etc.
This function should instead use a channel to block until the response is ready from the main thread.
It's likely there are more functions being called from not-the-main-thread.
The text was updated successfully, but these errors were encountered: