Add a curator to profile #1197
Open
Add a curator to profile #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katrin-kudryash
force-pushed
the
issues-1193
branch
2 times, most recently
from
0f65236
to
a6f4ac5
Compare
Katrin-kudryash
force-pushed
the
issues-1193
branch
2 times, most recently
from
836a7d7
to
3e945ad
Compare
Katrin-kudryash
force-pushed
the
issues-1193
branch
from
3e945ad
to
c797b47
Compare
nyet-ty
reviewed
Nov 18, 2024
| @@ -11,5 +11,7 @@ | |||
| "Retirement": "Увольнение", | |||
| "Transfer": "Перевод", | |||
| "Supplemental: ": "Дополнительно: ", | |||
| "Previous names": "Предыдущие ФИО" | |||
| "Previous names": "Предыдущие ФИО", | |||
| "Curator": "", | |||
tsumo
requested changes
Nov 18, 2024
|
Katrin-kudryash
force-pushed
the
issues-1193
branch
3 times, most recently
from
01efa78
to
f95f3e4
Compare
Katrin-kudryash
force-pushed
the
issues-1193
branch
from
f95f3e4
to
5d80242
Compare
Screen.mov |
Scr.mov |
Katrin-kudryash
force-pushed
the
issues-1193
branch
2 times, most recently
from
e49f023
to
65ebe45
Compare
tsumo
requested changes
Nov 21, 2024
| "Save previous name:": "Сохранить предыдущее ФИО" | ||
| "Save previous name:": "Сохранить предыдущее ФИО", | ||
| "Curators:": "Кураторы", | ||
| "Curator": "" |
| onClose: () => void; | ||
| } | ||
|
|
||
| interface UserFormExternalTeamBlockType { |
| const savePreviousName = watch('savePreviousName') ?? false; | ||
|
|
||
| const updateUser = async (data: EditUser) => { | ||
| await editUser(data); | ||
| onClose(); | ||
| }; | ||
|
|
||
| const onCuratorsChange = (users: User[], type: keyof UserFormExternalTeamBlockType) => { | ||
| setValue( |
There was a problem hiding this comment.
why not just setValue('curatorIds', ...)?
src/modules/externalUserTypes.ts
Outdated
| @@ -2,6 +2,7 @@ export interface ExternalUserUpdate { | |||
| email: string; | |||
| name?: string; | |||
| supervisorId?: string | null; | |||
| curators?: string[] | null; | |||
There was a problem hiding this comment.
Curators cannot be saved in external update
src/trpc/router/userRouter.ts
Outdated
| }, | ||
| { | ||
| name: result.name, | ||
| supervisorId: result.supervisorId, | ||
| organizationalUnitId: result.organizationUnitId ?? undefined, | ||
| email: result.email, | ||
| curatorIds: input.curatorIds, |
There was a problem hiding this comment.
Getting real list of curators would be more reliable than using input
asabotovich
requested changes
Nov 21, 2024
src/modules/userMethods.ts
Outdated
|
|
||
| if (curatorIds) { | ||
| updateUser.curators = { | ||
| connect: curatorIds.map((id) => ({ id })), |
There was a problem hiding this comment.
but where is disconnect?
Katrin-kudryash
force-pushed
the
issues-1193
branch
3 times, most recently
from
f5c208d
to
105db6e
Compare
Katrin-kudryash
force-pushed
the
issues-1193
branch
from
105db6e
to
c69be93
Compare
S.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Related issues
Resolve #1193