Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing git tag for releases #28

Closed
lfrancke opened this issue Jan 14, 2021 · 4 comments
Closed

Missing git tag for releases #28

lfrancke opened this issue Jan 14, 2021 · 4 comments

Comments

@lfrancke
Copy link

Hi,

it seems as if tags are missing for later releases (last one is 0.6.0).
Would you mind tagging the newer releases?

Thank you!

@tapeinosyne
Copy link
Owner

Hi @lfrancke, thanks for letting me know.

Would tagging the latest version (v0.8.0) suffice for now, or do you need all versions to be tagged for a specific purpose?

@lfrancke
Copy link
Author

Thanks for the quick response.

We ran a fossa.com check on our dependencies (it's all open source but I can't find a way to link to a FOSSA report with all the details) and it complains about hyphenation 0.7.1:
image
This is one example: image

So we wanted to check out the code at that revision and couldn't find it.
Which means we were especially interested in 0.7.1 but found it now. I opened this issue for the "general" problem as others might stumble across it as well.

It's not urgent at all though.

@tapeinosyne
Copy link
Owner

I went ahead and tagged all versions starting at v0.6, which should be enough.

On another note, if (L)GPL licensing is of concern to you, you might want to check out the brief discussion on #17. The short of it is that (L)GPL-licensed files are distributed as part of the hyphenation package, but never embedded in compiled build artifacts. If that is still problematic, do let me know.

(On yet another note, I am guessing hyphenation is not a direct dependency for you, but if it is, I'd be happy to open a PR to update to 0.8 — the API changes really are minimal.)

@lfrancke
Copy link
Author

Thank you very much for tagging. I'll close this issue.

And also thanks for the link to the earlier issue. That's very helpful.

You're right. It's not a direct dependency for us:
image

I believe all the intermediate dependencies are libraries with compatible Cargo.toml version specifiers so it's up to us to update our binary dependencies. When we tried that we actually found out that this is a false-positive for us as textwrap includes hyphenation only as a non-default feature so we don't even have a dependency on hyphenation. FOSSA doesn't parse features correctly yet.

Thank you for the offer to help even further though and thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants