Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Optimize tests for PLONK gadgets #140

Open
lazovicff opened this issue Jan 21, 2022 · 0 comments
Open

[TASK] Optimize tests for PLONK gadgets #140

lazovicff opened this issue Jan 21, 2022 · 0 comments

Comments

@lazovicff
Copy link
Contributor

lazovicff commented Jan 21, 2022 •
edited
Loading

Instead of creating a circuit for each test case for our PLONK gadgets, we should use the following function: https://github.com/ZK-Garage/plonk/blob/master/plonk-core/src/constraint_system/composer.rs#L541

The benefits:

  • We could debug in more detail which gate is not satisfying the constraints
  • More performant tests -- we dont need to go trough prove/verify process
  • Smaller code footprint

NOTE: This should only be done for out gadgets: PoseidonGadget, PathGadget, SetGadget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Webb Universe
Status: Not Started 🕧
Zero-knowledge
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazovicff @GhostOfGauss