Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved retrieval of current path from Windows File Explorer #1386

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amadea-system
Copy link

The old implementation of retrieving the current path from the title of the active File Explorer window only worked as long as the path was under 100 characters. Otherwise the title got truncated and no longer matched a valid path. This adds a new method of getting the path by pulling it directly from the address bar using accessibility elements.

I'm not sure if this works on Windows 11 as I am unable to test that currently. I suspect that with the large amount of changes that have been made to File Explorer it will likely need some adjustments to work properly on Windows 11. However, it should gracefully fall back to the old method if the address bar elements cannot be found.

@lunixbochs
Copy link
Collaborator

  1. don't import from talon.windows.ax, if Element isn't available in talon.ui I'll make it available
  2. merging this should be blocked on the 0.5 release, so it should maybe a be a draft PR
  3. windows accessibility isn't quite done, much of @nriley's accessibility coding style here is working around some of the incomplete aspects of windows accessibility that will be obsolete when it's finished in 0.5

@amadea-system
Copy link
Author

Thanks for the feedback!

  1. Element doesn't seem to be available in talon.ui yet.
  2. Since it definitely sounds like this is very premature, I'll go ahead change this to a draft PR for now.

@amadea-system amadea-system marked this pull request as draft February 18, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants