Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command server: manually specify the list of temporary directory environment variable names #1692

Open
phillco opened this issue Jan 19, 2025 · 1 comment

Comments

@phillco
Copy link
Collaborator

phillco commented Jan 19, 2025

cursorless-dev/talon-rpc#4 resolves an issue (#966) caused by the fact of that Python and NodeJS sometimes check for different environment variable names based on platform. It resolves this by hardcoding the variables to match what Python does.

We should probably do the same (pin the list) on the Python side so that neither implementation is depending on implicit stdlib behavior, in case it changes in the future. Although, this does raise the question of how to know if we need to make changes in the future.

@phillco phillco changed the title Command server: manly specify the list of temporary directory environment variable names Command server: manually specify the list of temporary directory environment variable names Jan 19, 2025
@nriley
Copy link
Collaborator

nriley commented Jan 19, 2025

My feeling is we shouldn't fix what isn't broken. The Python behavior has been stable for decades — this list of environment variables was last modified in 1997, and all but some custom Windows fallbacks is at least 20 years old. If further problems develop we could make things more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants