Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digits should be easier to customize (incl. alternative names for the same digit) #1564

Open
timo opened this issue Sep 24, 2024 · 3 comments
Assignees

Comments

@timo
Copy link
Contributor

timo commented Sep 24, 2024

digits = "zero one two three four five six seven eight nine".split()

Using a list here is neat from a "beautiful code" standpoint, but for making it customizable, it would be better to have either a .talon-list, or write out a dictionary with explicit word -> number pairs so a user who wants to change commands that use <user.number_key> (like the mouse grid for example) can just change or add lines

@timo
Copy link
Contributor Author

timo commented Sep 24, 2024

Also maybe there should either be unification or stronger/clearer distinction between words used for number_key and words used for full numbers

i'm looking at this particularly from the perspective of a non-coder who just needs some small tweaks to their commands

@nriley
Copy link
Collaborator

nriley commented Oct 12, 2024

Partially fixed in #1554 (for keys at least).

@nriley
Copy link
Collaborator

nriley commented Dec 14, 2024

We discussed this on the community backlog session today. Trying to define this with a Talon list would create the problem that we are trying to resolve in #1561. A potential solution we discussed and which was generally agreed would be helpful would be to define a single python file that just contains a dictionary of numbers to spoken form mappings; this could be imported by other files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants