Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabs to Inventory sidepanel #1082

Open
AllieMendes opened this issue Oct 11, 2023 · 25 comments
Open

Add tabs to Inventory sidepanel #1082

AllieMendes opened this issue Oct 11, 2023 · 25 comments
Labels

Comments

@AllieMendes
Copy link

Feature description
To match the sidepanel we want to introduce on the Resources Explorer page, two tabs need to be introduced on the sidepanel that opens when a user clicks on a resource.
The tab 'Resource details' should provide more information on the resource at hand and the tab 'Relations' should showcase the closest relations to that resource on a smaller version of the Explorer, with the option to open the explorer on that particular resource and everything surrounding it.

Resource details tab:
image

Relations:
image

Additional context
If you want to tackle this task, feel free to share with us your email address so we can give you access to the Figma project :)

@shavidze
Copy link
Contributor

Do we have some test accounts for cloud providers to reproduce this? I'm trying to use my current aws account but I can't see these tabs on the side panel just see

this

@AllieMendes
Copy link
Author

Do we have some test accounts for cloud providers to reproduce this? I'm trying to use my current aws account but I can't see these tabs on the side panel just see

this

The tabs don't exist yet, the ticket is to add those tabs to the side panel, in addition to the existing tags tab you see on your account

@shavidze
Copy link
Contributor

Can I take it?

@AllieMendes
Copy link
Author

Yes! I'll assign you @shavidze :)

@shavidze
Copy link
Contributor

shavidze commented Oct 21, 2023

@AllieMendes Do we have a design for it ?

@Traxmaxx I need help, What do you think about this dependency graph for some specific resource, should I write a separate API for it? or just filter after handling all the relations?

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Oct 24, 2023

@shavidze sorry for taking longer to get back to you. The Figma designs are linked above

I was not aware that we do not have an API yet to fetch a single ressource. I think it's a great idea to create an API for that first before continuing this sidepanel issue.

Should we open up a new issue to work on the API separately?

@shavidze
Copy link
Contributor

@Traxmaxx Yes, it would be nice

@Traxmaxx
Copy link
Contributor

@shavidze btw, we also have a need for this API in #1072 for the dependency graph.

@Traxmaxx
Copy link
Contributor

@shavidze I created #1136

@AllieMendes
Copy link
Author

@shavidze let me know your email so I can invite you to Figma so you can check the designs

@shavidze
Copy link
Contributor

Last update

My pull request about fetching a single resource is merged, and I'm ready to work on this feature.

@shavidze
Copy link
Contributor

shavidze commented Nov 3, 2023

@AllieMendes Do we need zoom buttons here, since we have zoom functionality on touch?

@AllieMendes
Copy link
Author

@AllieMendes Do we need zoom buttons here, since we have zoom functionality on touch?

I'm not sure I follow, what do you mean we have zoom functionality on touch?

@shavidze
Copy link
Contributor

shavidze commented Nov 3, 2023

@AllieMendes I mean , for example like it is on explorer page.
One more question, so if user clicks the open the explorer we should open on that particular resource and everything surrounding it, but with this logic it will span every resource that is related with the same cloud platform. Maybe I don't understand it right

@shavidze
Copy link
Contributor

shavidze commented Nov 4, 2023

Related PL

@mlabouardy
Copy link
Collaborator

@AllieMendes I mean , for example like it is on explorer page. One more question, so if user clicks the open the explorer we should open on that particular resource and everything surrounding it, but with this logic it will span every resource that is related with the same cloud platform. Maybe I don't understand it right

Hey @shavidze, regarding your question, if the user clicks on "open the explorer", we should take the user to the Explorer page with a filter "Resource ID is ID of the target resource" (we need to support Resource ID as a filter in the below dropdown menu):

Screenshot 2023-11-06 at 14 52 09

@AllieMendes
Copy link
Author

Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy?
And by opening the explorer, it would be ideal to have no filters on what resources are displayed

@shavidze
Copy link
Contributor

shavidze commented Nov 6, 2023

Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy?
And by opening the explorer, it would be ideal to have no filters on what resources are displayed

We don't introduce filter by resource name, we will support filter by resource id, so we can leverage that case to open single resource relations in the explorer.

But do we really need it? What is the purpose of it? @mlabouardy

@AllieMendes
Copy link
Author

According to the designs, we will support filter by resource name — therefore my question

@mlabouardy
Copy link
Collaborator

Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed

we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID

@AllieMendes
Copy link
Author

Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed

we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID

Got it, I'll add it to the Designs then!

@shavidze
Copy link
Contributor

Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed

we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID

Got it, I'll add it to the Designs then!

Do we have some updates?

@AllieMendes
Copy link
Author

Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed

we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID

Got it, I'll add it to the Designs then!

Do we have some updates?

Yes! Sorry for the delay, I was off.

So, for the visible filters, that the user can add, we'll keep the resource name as it wouldn't be intuitive for a user to search manually for a resource ID (and we would need to display it for all of them).

However, since we have access to this resource ID, when the user clicks on "Open in explorer" we can leverage it to point the user to the right area (without a visible filter on the filters bar, as it wouldn't change what's being displayed on screen).
The graph should still display all resources but be centered on the resource they were inspecting on the inventory.

Maybe @Traxmaxx can give some insights on how we can work with the positioning without filtering the graph.

@shavidze
Copy link
Contributor

@AllieMendes I'm sorry I couldn't work on this task past days, I'll definitely finish it tomorrow, I think everything is clear.

@shavidze
Copy link
Contributor

@AllieMendes Maybe we're ready to review PL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants