Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for kubernetes Controllers and add opencost cost calculation #1037

Closed
jakepage91 opened this issue Oct 4, 2023 · 8 comments · Fixed by #1057
Closed

Add suport for kubernetes Controllers and add opencost cost calculation #1037

jakepage91 opened this issue Oct 4, 2023 · 8 comments · Fixed by #1057

Comments

@jakepage91
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Using the Kubernetes pods file as an example, add support for Kubernetes controllers

Cost calculation for controllers can be added simply by following the example on line 21 of the pods file example simply passing the controller field

@shubhindia
Copy link
Contributor

@jakepage91 which controller exactly?

@Azanul
Copy link
Collaborator

Azanul commented Oct 6, 2023

@jakepage91 which controller exactly?

Opencost aggregates costs by k8s primitives. We don't need to pass a specific controller, we want to know how much cost is each controller incurring.

@shubhindia
Copy link
Contributor

There are multiple controllers. Goal is to cover all of them or just the ones which spawn pods?

@Azanul
Copy link
Collaborator

Azanul commented Oct 6, 2023

There are multiple controllers. Goal is to cover all of them or just the ones which spawn pods?

The high level goal is to calculate cost. Currently we use opencost integration to do so, hence we cover all kinds that opencost covers i.e., deployment, statefulset, daemonset and job.

@asamirr
Copy link
Contributor

asamirr commented Oct 9, 2023

We already have deployments implemented so we need to add 3 more files for statefulset, daemonset and job?

@shubhindia
Copy link
Contributor

shubhindia commented Oct 9, 2023

We already have deployments implemented so we need to add 3 more files for statefulset, daemonset and job?

That's what I was unclear about. Like, only the controllers which spawn pods or other controllers as well like PVC, Ingress etc? Is there any discussion channel available on slack or somewhere? Commenting here is just gonna increase the response time.

@asamirr
Copy link
Contributor

asamirr commented Oct 9, 2023

Discord

@jakepage91
Copy link
Contributor Author

jakepage91 commented Oct 9, 2023

Hey there @shubhindia feel free to joing the discord server, it will for sure reduce the reponse time. So yeah, I wrote up this issue with this section of the OpenCost API docs in mind. As you can see we can choose between controller and controllerKind but we only want to know what cost amount do all controllers incur for now, so I'm guessing that specifying the controller field will be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants