fix(3028): Use Arc to reduce clones and improve memory usage in dedupe #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
palash25
changed the title
|
Hey @palash25! Thank you for your contribution to Tailcall 🙏 Unfortunately, we cannot merge this PR as the changes proposed do not align with the requirements in the linked issue. I encourage you to review once again and open a new PR with the required changes. Thank you for your understanding 🙌 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 277 277
Lines 27674 27677 +3
=======================================
+ Hits 23975 23978 +3
Misses 3699 3699 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3028
/claim #3028
Summary:
This wraps
Valueused indedupe.rsin anArcto reduce the number of.clones()thereby reducing memory usageIssue Reference(s):
Fixes #3028
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>