Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Add type-safety when specifying needs of the jobs #63

Open
meskill opened this issue Nov 27, 2024 · 4 comments · Fixed by #70
Open

FR: Add type-safety when specifying needs of the jobs #63

meskill opened this issue Nov 27, 2024 · 4 comments · Fixed by #70

Comments

@meskill
Copy link
Contributor

meskill commented Nov 27, 2024

For now dependencies between jobs are specified as strings without any validation that could lead to invalid workflow file on generation.

image
@tusharmath tusharmath mentioned this issue Nov 28, 2024
Merged
@meskill
Copy link
Contributor Author

meskill commented Dec 2, 2024 •
edited
Loading

Reopening the issue since there are bugs from #70 in case user forgot to add dependency job with add_job the generated workflow is not valid:

image

  • The job id generated wrongly
  • The are duplicates of build job

@meskill meskill reopened this Dec 2, 2024
@meskill
Copy link
Contributor Author

meskill commented Dec 2, 2024

The first issue is fixed by #94

@tusharmath
Copy link
Contributor

@meskill I think this is fixed now in b6890cf

Can you verify this case again.

@meskill
Copy link
Contributor Author

meskill commented Dec 25, 2024

@meskill I think this is fixed now in b6890cf

Can you verify this case again.

Yes, looks like it fixed now.

I've added unit tests #112 to make sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: type safe job dependency tailcallhq/gh-workflow
2 participants
@tusharmath @meskill