Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blender] Support bundled ZIP format distrubtion #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Blender] Support bundled ZIP format distrubtion #60

wants to merge 4 commits into from

Conversation

archibate
Copy link
Contributor

@archibate archibate commented Sep 4, 2020 •
edited
Loading

Related issue = close #59

This allows users to install Taichi Elements like a trivial addon, like Stop-Motion-OBJ.zip does.
All the dependencies are included in Taichi-Elements.zip/bundle, which will be added to sys.path.

@codecov
Copy link

codecov bot commented Sep 5, 2020 •
edited
Loading

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files           3        3           
  Lines         517      517           
  Branches       98       98           
=======================================
  Hits          395      395           
  Misses         85       85           
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4182b...fa63c6e. Read the comment docs.

yuanming-hu
yuanming-hu approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delayed review. Everything LGTM here. Thanks for the PR!

I'm happy to merge this. What's the relationship between this and https://github.com/taichi-dev/taichi_blend?

blender/__init__.py Outdated Show resolved Hide resolved
@archibate
Copy link
Contributor Author

What's the relationship between this and https://github.com/taichi-dev/taichi_blend?

Not really, taichi_elements is only an importable PyPI package bundled with Taichi-Blend.

@archibate @yuanming-hu
Update blender/__init__.py
fa63c6e 
Co-authored-by: Yuanming Hu <[email protected]>
@archibate
Copy link
Contributor Author

Btw, how can I create a node scene in blender for taichi_blend, like taichi_elements does? I'd like to connect solvers / renders using node system instead of writing code.

@PavelBlend
Copy link
Collaborator

@archibate hello.

I can help write a node system for taichi_blend like in taichi_elements. I will create an issue in the taichi_blend repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Blender] Deploy in ZIP format for Blender-friendly addon installation
3 participants
@archibate @PavelBlend @yuanming-hu