From 52e431a0e401c76b70d51f8900684fed9c92cebe Mon Sep 17 00:00:00 2001 From: "bar.r" Date: Wed, 22 Nov 2023 12:05:57 +0200 Subject: [PATCH 1/4] tmax --- modules/taboolaBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/taboolaBidAdapter.js b/modules/taboolaBidAdapter.js index 8a42013b0..586a6f0b0 100644 --- a/modules/taboolaBidAdapter.js +++ b/modules/taboolaBidAdapter.js @@ -125,7 +125,7 @@ export const spec = { site, device, source: {fd: 1}, - tmax: bidderRequest.timeout, + tmax: parseInt(bidderRequest.timeout), bcat: ortb2.bcat || bidRequest.params.bcat || [], badv: ortb2.badv || bidRequest.params.badv || [], wlang: ortb2.wlang || bidRequest.params.wlang || [], From 86e39c4f7b5d7f1e4eef18847b0c8d15210902dc Mon Sep 17 00:00:00 2001 From: "bar.r" Date: Sun, 26 Nov 2023 15:24:40 +0200 Subject: [PATCH 2/4] tmax --- modules/taboolaBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/taboolaBidAdapter.js b/modules/taboolaBidAdapter.js index 586a6f0b0..1ef66cd7f 100644 --- a/modules/taboolaBidAdapter.js +++ b/modules/taboolaBidAdapter.js @@ -125,7 +125,7 @@ export const spec = { site, device, source: {fd: 1}, - tmax: parseInt(bidderRequest.timeout), + tmax: (bidderRequest.timeout == undefined) ? undefined : parseInt(bidderRequest.timeout), bcat: ortb2.bcat || bidRequest.params.bcat || [], badv: ortb2.badv || bidRequest.params.badv || [], wlang: ortb2.wlang || bidRequest.params.wlang || [], From 08aea3151df396334194da61eb6a12af75bc1a00 Mon Sep 17 00:00:00 2001 From: "bar.r" Date: Mon, 27 Nov 2023 11:56:49 +0200 Subject: [PATCH 3/4] tmax --- test/spec/modules/taboolaBidAdapter_spec.js | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/test/spec/modules/taboolaBidAdapter_spec.js b/test/spec/modules/taboolaBidAdapter_spec.js index 7d31e2916..5964cc084 100644 --- a/test/spec/modules/taboolaBidAdapter_spec.js +++ b/test/spec/modules/taboolaBidAdapter_spec.js @@ -275,6 +275,26 @@ describe('Taboola Adapter', function () { expect(resData.tmax).to.equal(500); }); + it('should pass bidder timeout as a string', function () { + const bidderRequest = { + ...commonBidderRequest, + timeout: '500' + } + const res = spec.buildRequests([defaultBidRequest], bidderRequest); + const resData = JSON.parse(res.data); + expect(resData.tmax).to.equal(500); + }); + + it('should pass bidder timeout as a string', function () { + const bidderRequest = { + ...commonBidderRequest, + timeout: null + } + const res = spec.buildRequests([defaultBidRequest], bidderRequest); + const resData = JSON.parse(res.data); + expect(resData.tmax).to.equal(undefined); + }); + describe('first party data', function () { it('should parse first party data', function () { const bidderRequest = { From e1dde7b5cb67fd4c2805cea5c24080fbf9fbfbc5 Mon Sep 17 00:00:00 2001 From: "bar.r" Date: Mon, 27 Nov 2023 12:22:54 +0200 Subject: [PATCH 4/4] tmax --- test/spec/modules/taboolaBidAdapter_spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/spec/modules/taboolaBidAdapter_spec.js b/test/spec/modules/taboolaBidAdapter_spec.js index 5964cc084..21a60be6a 100644 --- a/test/spec/modules/taboolaBidAdapter_spec.js +++ b/test/spec/modules/taboolaBidAdapter_spec.js @@ -275,7 +275,7 @@ describe('Taboola Adapter', function () { expect(resData.tmax).to.equal(500); }); - it('should pass bidder timeout as a string', function () { + it('should pass bidder tmax as int', function () { const bidderRequest = { ...commonBidderRequest, timeout: '500' @@ -285,7 +285,7 @@ describe('Taboola Adapter', function () { expect(resData.tmax).to.equal(500); }); - it('should pass bidder timeout as a string', function () { + it('should pass bidder timeout as null', function () { const bidderRequest = { ...commonBidderRequest, timeout: null