feat: add vite import massager plugin

This should improve eslint performance for negligable vite performance as the straight string transforms are faster than the TS parsing needed for the eslint-plugin rule BREAKING CHANGE: eslint-plugin has ‘forbidden imports’ replaced with vite plugin
tablecheck · Sep 12, 2024 · 6c0c2f9 · 6c0c2f9
1 parent 102dd97
commit 6c0c2f9
Show file tree

Hide file tree

Showing 22 changed files with 688 additions and 324 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -71,7 +71,7 @@
     "storybook": "^6.5.16",
     "type-fest": "4.4.0",
     "typescript": "5.4.5",
-    "vite": "5.3.1",
+    "vite": "5.3.5",
     "vite-plugin-eslint": "^1.8.1",
     "vite-tsconfig-paths": "4.3.2",
     "vitest": "1.6.0"

diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -84,7 +84,7 @@
   },
   "devDependencies": {
     "eslint": "^8",
-    "vite": "5.3.1",
+    "vite": "5.3.5",
     "vite-tsconfig-paths": "4.3.2"
   },
   "engines": {

diff --git a/packages/eslint-config/src/rules/general.ts b/packages/eslint-config/src/rules/general.ts
@@ -101,6 +101,5 @@ export const generalRules: Linter.RulesRecord = {
     },
   ],
   'no-unused-vars': 'error',
-  '@tablecheck/forbidden-imports': 'error',
   '@nx/enforce-module-boundaries': 'error',
 };
diff --git a/packages/eslint-plugin/README.md b/packages/eslint-plugin/README.md
@@ -21,10 +21,9 @@ npm install --save-dev @tablecheck/eslint-plugin
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
 💭 Requires type information.
 
-| Name                                                             | Description                                                                                 | 🔧  | 💭  |
-| :--------------------------------------------------------------- | :------------------------------------------------------------------------------------------ | :-- | :-- |
-| [consistent-react-import](docs/rules/consistent-react-import.md) | Ensure that react is always imported and used consistently                                  | 🔧  |     |
-| [forbidden-imports](docs/rules/forbidden-imports.md)             | Ensure that certain packages are using specific imports instead of using the default import | 🔧  |     |
-| [prefer-shortest-import](docs/rules/prefer-shortest-import.md)   | Enforce the consistent use of preferred import paths                                        | 🔧  | 💭  |
+| Name                                                             | Description                                                | 🔧  | 💭  |
+| :--------------------------------------------------------------- | :--------------------------------------------------------- | :-- | :-- |
+| [consistent-react-import](docs/rules/consistent-react-import.md) | Ensure that react is always imported and used consistently | 🔧  |     |
+| [prefer-shortest-import](docs/rules/prefer-shortest-import.md)   | Enforce the consistent use of preferred import paths       | 🔧  | 💭  |
 
 <!-- end auto-generated rules list -->
diff --git a/packages/eslint-plugin/__tests__/forbiddenImports.test.ts b/packages/eslint-plugin/__tests__/forbiddenImports.test.ts
diff --git a/packages/eslint-plugin/docs/rules/forbidden-imports.md b/packages/eslint-plugin/docs/rules/forbidden-imports.md
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -36,7 +36,7 @@
     "prettier": "3.0.3",
     "type-fest": "4.4.0",
     "typescript": "5.1.6",
-    "vite": "5.3.1",
+    "vite": "5.3.5",
     "vite-tsconfig-paths": "4.3.2",
     "vitest": "1.6.0"
   },