Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the architectural issue with the package #266

Open
t73biz opened this issue Jul 21, 2024 · 0 comments
Open

Fix the architectural issue with the package #266

t73biz opened this issue Jul 21, 2024 · 0 comments
Assignees
Labels
bug Something isn't working components
Milestone

Comments

@t73biz
Copy link
Owner

t73biz commented Jul 21, 2024

What happened?

Fix the architectural issue with the package
The package is engineered backwareds and doesn't hold to the promise of seperation of concerns.
There isn't a "slot" property for Live wire for a reason. We should convert the components from Livewire to Blade.

How to reproduce the bug

There is a problem when using the components in that there is a closing tag applied.
Blade components should be embeded into Livewire components, not the other way around.

Package Version

1.0.0

PHP Version

8.3.0

Laravel Version

11

Which operating systems does with happen with?

Linux

Notes

Major change required. Might just move the 1.0 tag hash afterwards.

@t73biz t73biz added the bug Something isn't working label Jul 21, 2024
@t73biz t73biz self-assigned this Jul 21, 2024
@t73biz t73biz added this to the 1.0 milestone Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working components
Projects
None yet
Development

No branches or pull requests

1 participant