Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught error appears when using zone.js #538

Open
MichaelJCole opened this issue Feb 20, 2016 · 6 comments
Open

Uncaught error appears when using zone.js #538

MichaelJCole opened this issue Feb 20, 2016 · 6 comments

Comments

@MichaelJCole
Copy link

Hi, zone.js is used in zones, which is used by Meteor's Kadira for in browser error reporting to a server.

sweetalert has an error, which doesn't seem to bother chrome, but when combined with zone.js prevents the callback from being called.

I tried to explain it here: meteorhacks/zones#85
and here: https://github.com/angular/zone.js/issues/260

Those issues are about zone.js, but this is the root cause:

Error: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'.
TypeError: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'.
    at TypeError (native)
    at s (https://dashboard-dev.hello.io/packages/patrickml_swal.js?06d775f51a9debdd71fd5de7eb0594d0e94eed1b:32:7559)
    at HTMLButtonElement.p (https://dashboard-dev.hello.io/packages/patrickml_swal.js?06d775f51a9debdd71fd5de7eb0594d0e94eed1b:32:3375)
@YannDanthu
Copy link

YannDanthu commented Apr 21, 2016

Hi, same error here with firefox only (Safari and Chrome do not seem to report the error)

Did you fix it @MichaelJCole or do you still have the error ?

@MichaelJCole
Copy link
Author

I didn't find a fix. Needed SweetAlert more than Zones, so removed it. Zones was part of Kadira client error reporting.

@YannDanthu
Copy link

ok, we are going to check with meteor kevohagan:sweetalert (more up to date with latest sweetalert version) if the pb still occurs or not.

@YannDanthu
Copy link

Ok, no more error with kevohagan:sweetalert but other problem occurs with zone.js I suppose.
Sweetalert will always call the first callback registered in sweetalert :(

We have moved to Meteor 1.3 so no more atmosphere package for sweetalert but still have the zone.js bug. (need to remove zone.js to double check)

@MichaelJCole
Copy link
Author

Hey Yann, if you're interested, I filed a bug with zone.js: https://github.com/angular/zone.js/issues/260

@t4t5
Copy link
Owner

t4t5 commented Sep 8, 2017

Hey guys! Could you check if this problem persists with the latest release? You will probably need to refactor your apps a bit though, so make sure you check out the upgrade guide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants