Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t3onoff breaks radio fieldsets #516

Open
cheesegrits opened this issue Dec 19, 2017 · 0 comments
Open

t3onoff breaks radio fieldsets #516

cheesegrits opened this issue Dec 19, 2017 · 0 comments

Comments

@cheesegrits
Copy link

The current code for the t3onoff buttons breaks any such fieldsets (containing two radio inputs with 0 and 1 as values) that don't have the input before the label.

I've submitted a PR:

#515

... to use the 'for' property of the label to get the input, rather then relying on the DOM structure.
using prev() .

Note that the existing code already uses the 'for' property in the listener a few lines later, so already relies on there being a 'for'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant