Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Register fuel information to Rocket.ROCKET_TO_PROPERTIES #4

Open
gisellevonbingen opened this issue Dec 5, 2024 · 2 comments

Comments

@gisellevonbingen
Copy link

Came from gisellevonbingen-Minecraft/Ad-Astra-Giselle-Addon/issues/73

^ This issue's cause is missing null check as you looks.
What I want to say is this mod's rockets are does not register fuel information to Rocket.ROCKET_TO_PROPERTIES.
https://github.com/terrarium-earth/Ad-Astra/blob/bfa70ac3db6dca1c02ed6fad5be62649b2c23906/common/src/main/java/earth/terrarium/adastra/common/entities/vehicles/Rocket.java#L63-L67

So, other mods can't be know what kind of fuel this mod's rockets are using for now.
An example.
https://github.com/gisellevonbingen-Minecraft/Ad-Astra-Giselle-Addon/blob/25da6e47b946c7de83860eb72b10ed83078d14c1/common/src/main/java/ad_astra_giselle_addon/common/entity/VehicleHelper.java#L17-L18

@DRD2k8
Copy link

DRD2k8 commented Dec 8, 2024

I made a commit so we'll see if this fixes the issue once 1.1.3 of this mod comes out.

@DRD2k8
Copy link

DRD2k8 commented Dec 8, 2024

And next time, report issues to my fork of the website and not the discontinued one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants