Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo 52 #1248

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Expo 52 #1248

wants to merge 9 commits into from

Conversation

czystyl
Copy link

@czystyl czystyl commented Nov 18, 2024

Update the Mobile app to use Expo v52 and related packages.

Additionally:

@czystyl czystyl changed the title Update mobile app to Expo52 Expo 52 Nov 18, 2024
@kiikoh
Copy link

kiikoh commented Nov 18, 2024

EXPO_USE_METRO_WORKSPACE_ROOT is now enabled by default. The monorepo root is considered to "contain all content", the workspace root adds something called "server root" besides the "project root". This fixes a couple of things related to: resolution to workspaces in the monorepo, splitting the Metro cache for near-identical apps in the same monorepo, using the correct entry point resolution in various cases.
Metro will now be automatically configured to support pnpm monorepos. Learn more.

From: https://expo.dev/changelog/2024/11-12-sdk-52

Is there any simplifications that can be made to the metro configuration as a result of this? Can hoist be removed?

@VaniaPopovic
Copy link
Contributor

VaniaPopovic commented Nov 18, 2024

Can we bump nativewind + remove "react-native-css-interop": "~0.0.36", as part of this? Nativewind 4.1.x contains a lot of fixes

P.S think there are some changes in expo-splash-screen as well

@czystyl
Copy link
Author

czystyl commented Nov 19, 2024

Can we bump nativewind + remove "react-native-css-interop": "~0.0.36", as part of this? Nativewind 4.1.x contains a lot of fixes

P.S think there are some changes in expo-splash-screen as well

Is react-native-css-interop not needed anymore?

@czystyl
Copy link
Author

czystyl commented Nov 19, 2024

EXPO_USE_METRO_WORKSPACE_ROOT is now enabled by default. The monorepo root is considered to "contain all content", the workspace root adds something called "server root" besides the "project root". This fixes a couple of things related to: resolution to workspaces in the monorepo, splitting the Metro cache for near-identical apps in the same monorepo, using the correct entry point resolution in various cases.
Metro will now be automatically configured to support pnpm monorepos. Learn more.

From: https://expo.dev/changelog/2024/11-12-sdk-52

Is there any simplifications that can be made to the metro configuration as a result of this? Can hoist be removed?

I don't see anything that can be simplified at this moment. I'm upgrading two other production apps that use monorepo, so If anything pops up, I'll transfer it here as well.

@czystyl czystyl marked this pull request as draft November 19, 2024 11:20
@czystyl
Copy link
Author

czystyl commented Nov 19, 2024

I've encountered development build problems, so converting the PR back to draft.

@juliusmarminge
Copy link
Member

we should be able to remove the hoisting now right? Expo 52 promised to fix monorepos 🤞🏼

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaniaPopovic will run some sanity checks tomorrow (potentially add back granular hoisting since EAS might not play nice otherwise) but LGTM :)

@czystyl
Copy link
Author

czystyl commented Nov 27, 2024

@VaniaPopovic will run some sanity checks tomorrow (potentially add back granular hoisting since EAS might not play nice otherwise) but LGTM :)

Thanks @juliusmarminge, for jumping in!

I've had weird issues with the build itself, but let me know if you need anything else to test.

@kiikoh
Copy link

kiikoh commented Nov 27, 2024

FWIW: I also had issues applying these changes to my t3-turbo project but had problems getting it to build properly. Although its very possible that my issues are from the additional packages I've added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Readme schema link is broken
4 participants