-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expo 52 #1248
base: main
Are you sure you want to change the base?
Expo 52 #1248
Conversation
From: https://expo.dev/changelog/2024/11-12-sdk-52 Is there any simplifications that can be made to the metro configuration as a result of this? Can hoist be removed? |
Can we bump nativewind + remove "react-native-css-interop": "~0.0.36", as part of this? Nativewind 4.1.x contains a lot of fixes P.S think there are some changes in expo-splash-screen as well |
Is |
I don't see anything that can be simplified at this moment. I'm upgrading two other production apps that use monorepo, so If anything pops up, I'll transfer it here as well. |
I've encountered development build problems, so converting the PR back to draft. |
we should be able to remove the hoisting now right? Expo 52 promised to fix monorepos 🤞🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VaniaPopovic will run some sanity checks tomorrow (potentially add back granular hoisting since EAS might not play nice otherwise) but LGTM :)
Thanks @juliusmarminge, for jumping in! I've had weird issues with the build itself, but let me know if you need anything else to test. |
FWIW: I also had issues applying these changes to my t3-turbo project but had problems getting it to build properly. Although its very possible that my issues are from the additional packages I've added |
Update the Mobile app to use Expo v52 and related packages.
Additionally:
The field "cli.appVersionSource" is not set, but it will be required in the future.
warning