Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lucia auth option #1611

Closed
wants to merge 18 commits into from
Closed

feat: add lucia auth option #1611

wants to merge 18 commits into from

Conversation

ronanru
Copy link
Contributor

@ronanru ronanru commented Oct 19, 2023

Closes #1606
Related to #1593

Lucia Auth is a popular alternative to NextAuth, and I think it will be a great addition to ct3a

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Added an option for Lucia Auth

Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: dec448c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 8:55pm

@vercel
Copy link

vercel bot commented Oct 19, 2023

@ronanru is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 19, 2023
@ronanru ronanru marked this pull request as draft October 20, 2023 10:32
@ronanru ronanru marked this pull request as ready for review October 20, 2023 10:34
@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Oct 30, 2023
@dominik-sfl
Copy link

is this happening? would love to see this integrated.

@juliusmarminge
Copy link
Member

Hey @ronanru, thank you for putting in the effort for this and the db option PR.

However, we have decided not to add Lucia as an auth option as we don't see the value it adds over next-auth, especially with it's auth.js port around the corner with v5.

Me and @c-ehrlich will try and get the db option PR merged soon though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: adding Lucia for Authentication
4 participants