Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete entire mention with 2 backspace #128

Open
paul-lavoine opened this issue Feb 11, 2020 · 5 comments
Open

Delete entire mention with 2 backspace #128

paul-lavoine opened this issue Feb 11, 2020 · 5 comments
Assignees

Comments

@paul-lavoine
Copy link

Hello,

removeEntireMention= true parameters allow to remove entire mention with backspace.

removeEntireMention= false parameter allows to highlight mention on the first backspace then unhighlight mention and only keeping text.

Is possible to highlight mention on the first backspace then remove entire mention with a second backspace ?

Thanks for helping

@szweier
Copy link
Owner

szweier commented Feb 15, 2020

The only two options that exist at the moment are:
removeEntireMention= true: The result here is that if you delete any part of a mention the entire mention is removed.
removeEntireMention= false: The result here is that if you edit any part of a mention the text loses its highlight and the mention is removed from the mentions array (essentially the remaining text becomes plain text).

Can you describe to me a bit more what exactly you were hoping to have happen?

@paul-lavoine
Copy link
Author

paul-lavoine commented Feb 19, 2020

I would like to highlight the mention then remove the entire mention.

I dont want to remove only the highlight. I want the text the entire mention disappears.

@szweier
Copy link
Owner

szweier commented Feb 19, 2020

I would like to highlight the mention then remove the entire mention.

I dont want to remove only the highlight. I want the text the entire mention disappears.

Oh I see. At the moment I don’t have that functionality. I’ll see about adding that in as another option shortly. Thanks for the suggestion.

@szweier szweier self-assigned this Feb 19, 2020
@szweier
Copy link
Owner

szweier commented Feb 19, 2020

Out of curiosity are you hoping for the selection range to be over the entire mention to show that the mention will be removed entirely or do you just want the deletion of any character within the mention to result in the entire mention text being removed.

@paul-lavoine
Copy link
Author

I hope for the selection range to be over the entire mention to show that the mention will be removed entirely ;) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants