Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.x Branch and release #9

Open
jbielick opened this issue Jul 19, 2018 · 1 comment
Open

0.5.x Branch and release #9

jbielick opened this issue Jul 19, 2018 · 1 comment

Comments

@jbielick
Copy link
Contributor

Greetings, @szajbus

We recently encountered a case in which we needed to constrain the element matches to those within a parent element.

We implemented this functionality in this commit and will use our fork to solve the problem in our application. We had to write this feature against 0.5.2 because we're still on 0.5.2—some later releases like 0.6 and 0.7 had breaking API changes that we are unable to upgrade to.

I'm wondering how you feel about the functionality implemented before I try to pull request it against this repo. If you were interested, I would request that we create a 0.5.x branch, implement the feature, tag a 0.5.3 release, and publish it. I could then port the feature to the 0.7.0 tip.

@szajbus
Copy link
Owner

szajbus commented Jul 23, 2018

Hi @jbielick,

I think it would be a really good addition to the library and would love to see it implemented. I'm happy to publish it to 0.5.x and 0.7.x lines.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants