Replies: 1 comment 1 reply
-
That's pretty neat and a worthwhile saving, especially when scaling up to the planet. I'd be happy to go for that but I think definitely |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This has the potential to be disruptive to users, so I figured I'd start a discussion here before making a PR against Tilemaker proper.
cldellow#1 changes how the Lua interop works, reducing read time by 7.5% (wall clock) or 11.5% (user time)
Would you be open to this change? I can see how the current approach would feel quite familiar to folks and provides a nice namespacing benefit.
If you were open to it, would you prefer it against master or refactor_geometries?
Argument in favour of master: The nature of the change is that it will create ongoing merge conflicts in process.lua, so it'll make merging master into refactor_geometries more painful.
Argument in favour of refactor_geometries: it's a breaking change to something user-facing.
Beta Was this translation helpful? Give feedback.
All reactions