Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v252 batch #418

Merged
merged 9 commits into from
Jun 25, 2024
Merged

v252 batch #418

merged 9 commits into from
Jun 25, 2024

Conversation

bluca
Copy link
Member

@bluca bluca commented Jun 25, 2024

No description provided.

yuwata and others added 9 commits June 25, 2024 19:33
@yuwata @bluca
sd-dhcp-server: clear buffer before receive
527e185 
I do not think this is necessary, but all other places in
libsystemd-network we clear buffer before receive. Without this,
Coverity warns about use-of-uninitialized-values.
Let's silence Coverity.

Closes CID#1469721.

(cherry picked from commit 40f9fa0)
(cherry picked from commit 0d573787ea1610ba57a359cf437841f62b186e77)
(cherry picked from commit aa93c07)
(cherry picked from commit 74e844a)
(cherry picked from commit 3010073)
@DaanDeMeyer @bluca
rules: Limit the number of device units generated for serial ttys
c6c9ffd 
As per the suggestion in systemd/systemd#33242.

This reduces the number of /dev/ttySXX device units generated in
mkosi from 32 to 4.

(cherry picked from commit dc38f9a)
(cherry picked from commit a3d94332a2b5128697373d3093c1cfa56649ec61)
(cherry picked from commit 6391242)
(cherry picked from commit 1a8549f)
(cherry picked from commit 38f11f4)
@q66 @bluca
strbuf: use GREEDY_REALLOC to grow the buffer
d1c9c8f 
This allows us to reserve a bunch of capacity ahead of time,
improving the performance of hwdb significantly thanks to not
having to reallocate so many times.

Before:
```
$ sudo time valgrind --leak-check=full ./systemd-hwdb update
==113297== Memcheck, a memory error detector
==113297== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.
==113297== Using Valgrind-3.23.0 and LibVEX; rerun with -h for copyright info
==113297== Command: ./systemd-hwdb update
==113297==
==113297==
==113297== HEAP SUMMARY:
==113297==     in use at exit: 0 bytes in 0 blocks
==113297==   total heap usage: 1,412,640 allocs, 1,412,640 frees, 117,920,009,195 bytes allocated
==113297==
==113297== All heap blocks were freed -- no leaks are possible
==113297==
==113297== For lists of detected and suppressed errors, rerun with: -s
==113297== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
132.44user 21.15system 2:35.61elapsed 98%CPU (0avgtext+0avgdata 228560maxresident)k
0inputs+25296outputs (0major+6886930minor)pagefaults 0swaps
```

After:
```
$ sudo time valgrind --leak-check=full ./systemd-hwdb update
==112572== Memcheck, a memory error detector
==112572== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.
==112572== Using Valgrind-3.23.0 and LibVEX; rerun with -h for copyright info
==112572== Command: ./systemd-hwdb update
==112572==
==112572==
==112572== HEAP SUMMARY:
==112572==     in use at exit: 0 bytes in 0 blocks
==112572==   total heap usage: 1,320,113 allocs, 1,320,113 frees, 70,614,501 bytes allocated
==112572==
==112572== All heap blocks were freed -- no leaks are possible
==112572==
==112572== For lists of detected and suppressed errors, rerun with: -s
==112572== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
21.94user 0.19system 0:22.23elapsed 99%CPU (0avgtext+0avgdata 229876maxresident)k
0inputs+25264outputs (0major+57275minor)pagefaults 0swaps
```

Co-authored-by: Yu Watanabe <[email protected]>
(cherry picked from commit 621b10f)
(cherry picked from commit 514ef0f93b76cbe0ba6b4de07a7b21fd0c2b7bae)
(cherry picked from commit aa0dd89)
(cherry picked from commit 43ee651)
(cherry picked from commit 732b645)
@rpigott @bluca
resolved: permit dnssec rrtype questions when we aren't validating
5a8bcc6 
This check introduced in 91adc4d is intended to spare us from
encountering broken resolver behavior we don't want to deal with.
However if we aren't validating we more than likely don't know the state
of the upstream resolver's support for dnssec. Let's let clients try
these queries if they want.

This brings the behavior of sd-resolved in-line with previouly stated
change in the meaning of DNSSEC=no, which now means "don't validate"
rather than "don't validate, because the upstream resolver is declared to
be dnssec-unaware".

Fixes: 9c47b33 ("resolved: enable DNS proxy mode if client wants DNSSEC")
(cherry picked from commit 364c948)
(cherry picked from commit ba031f1fe86e36d7adc0340b047de32399c98bf7)
(cherry picked from commit 5299397)
(cherry picked from commit a3a035e)
(cherry picked from commit 9806095)
@YHNdnzj @bluca
man,units: drop "temporary" from description of systemd-tmpfiles
46648a6 
Historically, systemd-tmpfiles was designed to manager temporary
files, but nowadays it has become a generic tool for managing
all kinds of files. To avoid user confusion, let's remove "temporary"
from the tool's description.

As discussed in #33349

(cherry picked from commit b5c8cc0a3b8e4e2fea0539d6420a76b524ea5735)
(cherry picked from commit 1a0e6961cfaed42bda542e111738c136f7b4d73f)
(cherry picked from commit c752efd)
(cherry picked from commit 269fb21)
(cherry picked from commit dea4c37)
@YHNdnzj @bluca
core/service: fix accept-socket deserialization
75697d6 
Follow-up for 45b1017

(cherry picked from commit 9f5d8c3da4f505346bd1edfae907a2abcdbdc578)
(cherry picked from commit f7d55cc801611781fbff2817f2fd4a16ec96ca85)
(cherry picked from commit 8ead254)
(cherry picked from commit 8f28021)
(cherry picked from commit 72c1768)
@bluca
install: allow removing symlinks even for units that are gone
ce74c50 
If a symlink is leftover, still allow cleaning it up via 'disable'. This
happens when a unit is stopped and removed, but not disabled, and a reload
has already happened. At that point, cleaning up the old symlinks becomes
impossible through the APIs, and needs to be done manually. Always allow
cleaning up symlinks, if they exist, by only erroring out if there is an
OOM.

Follow-up for f31f10a

(cherry picked from commit 5163c9b1e56293b1bb2803420613c5b374570892)
(cherry picked from commit c26e56d08f30a2946dfa1d03781c63bfa9f56c1d)
(cherry picked from commit 44c08e6)
(cherry picked from commit 8c9fcb5)
(cherry picked from commit e969f8b)
@yuwata @bluca
missing_loop.h: fix LOOP_SET_STATUS_SETTABLE_FLAGS
b3f613f 
See https://github.com/torvalds/linux/blob/v6.10-rc1/include/uapi/linux/loop.h

Fixes a bug in b3fe33f.

(cherry picked from commit eb6d3a5)
(cherry picked from commit b097677)
(cherry picked from commit f224a9d)
(cherry picked from commit dad62c7)
@kszczek @bluca
json: use secure un{base64,hex}mem for sensitive variants
c7c2883 
While tracing a LUKS code path in homework, I've noticed that we don't
erase buffers when doing unbase64 or unhex on JSON variants, even if the
variant is marked as sensitive.

(cherry picked from commit 80313c5)
(cherry picked from commit cce7df4)
(cherry picked from commit 2dee004)
(cherry picked from commit d5a7b54)
@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/systemd-systemd-stable-418 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=systemd-systemd-stable-418 chroots=[]): chroots: '[]' is not a valid choice for this field.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@bluca bluca merged commit 9c48a48 into systemd:v252-stable Jun 25, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
network resolve units
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bluca @yuwata @DaanDeMeyer @q66 @rpigott @YHNdnzj @kszczek