Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEIC image support? #371

Closed
1 of 3 tasks
joffer77 opened this issue Dec 8, 2024 · 7 comments
Closed
1 of 3 tasks

HEIC image support? #371

joffer77 opened this issue Dec 8, 2024 · 7 comments
Labels
⬆️ enhancement New feature or request

Comments

@joffer77
Copy link

joffer77 commented Dec 8, 2024

What is the problem you are trying to solve with this feature?

Will there be support for using pictures in .HEIC format when registering items? Both iPhone and Android now uses this.

What is the solution you are proposing?

Add support for HEIC format

What alternatives have you considered?

Converting HEIC into JPEG, but it's just extra hassle

Additional context

No response

Contributions

  • I have searched through existing issues and feature requests to see if my idea has already been proposed.
  • If this feature is accepted, I would be willing to help implement and maintain this feature.
  • If this feature is accepted, I'm willing to sponsor the development of this feature.
@joffer77 joffer77 added the ⬆️ enhancement New feature or request label Dec 8, 2024
@101br03k
Copy link
Contributor

101br03k commented Dec 8, 2024

well, yes the phone and phone gallery etc do support heic on android, but I am not so sure about the browser, is it not that only safari supports heic nativly?

@joffer77
Copy link
Author

joffer77 commented Dec 8, 2024

Could HEIC be uploaded and converted to jpg/webp maybe in the process during upload of photo (HEIC)?
On the computer it's a bit easier to manually convert HEIC to jpg first, but not so much from the phone.

@tankerkiller125
Copy link
Contributor

tankerkiller125 commented Dec 8, 2024

Please see:

#165
#369

iPhones from my understanding auto convert to a format supported by the upload format. At least when added during item creation. I'm not sure how this looks once your in the editing an item side of things.

I do not own Apple devices, and thus have no way to test anything related to them.

@101br03k
Copy link
Contributor

101br03k commented Dec 9, 2024

Could HEIC be uploaded and converted to jpg/webp maybe in the process during upload of photo (HEIC)? On the computer it's a bit easier to manually convert HEIC to jpg first, but not so much from the phone.

Mayby check out https://github.com/C4illin/ConvertX, it does support heic converting.

@harrisony
Copy link
Contributor

I suppose the question is, are you more interested in storing HEIC's or serving HEIC's.

If the answer is the latter, you would be better off using @nuxt/image (which includes a preconfigured local option in IPX or allows you to use a third party if thats your thing)

@tankerkiller125
Copy link
Contributor

tankerkiller125 commented Jan 4, 2025

@harrisony @nuxt/image only works when Nuxt is in server-side rendering mode, or using an external provider (of which Homebox will not do or force), given we don't use server side rendering mode in production this library simply would not work for Homebox, and Homebox does in fact require it's own backend image conversion/optimization tooling.

@tankerkiller125
Copy link
Contributor

Closing as part of #265 which will include image manipulation/conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants