Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour for empty external responses #167

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

michael-e
Copy link
Member

The file_put_contents function will return 0 if empty content is written, but this should not trigger a writing exception. Empty content should throw an exception before, when checking the curl response.

Fixes #164

The file_put_contents function will return 0 if empty content is written, but this should not trigger a writing exception. Empty content should throw an exception before, when checking the curl response.

Fixes symphonycms#164
@michael-e michael-e requested a review from nitriques February 28, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant