You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I’m thinking that some documentation could help contributors here (perhaps I missed it).
Especially regarding the tools used in the CI that we don’t often see in Symfony repositories, such as PHPStan and TwigCS. Again, I may have missed something, but the Composer scripts do not seem to be designed with contributors in mind.
Maybe a simple “How to Contribute” section in the documentation or a dedicated CONTRIBUTING.md file would be beneficial?
Additionally, what about removing TwigCS and starting to use Twig-CS-Fixer by @VincentLanglet, which attentively follows all Twig changes and best practices TwigCS is officially EOL and, to my knowledge, has only added minimal support for new PHP releases in the last two years.
(These are just personal comments based on my experience this afternoon. Feel free to close this if I’m out of bounds.)
The text was updated successfully, but these errors were encountered:
Additionally, what about removing TwigCS and starting to use Twig-CS-Fixer by @VincentLanglet, which attentively follows all Twig changes and best practices TwigCS is officially EOL and, to my knowledge, has only added minimal support for new PHP releases in the last two years.
Well.. except compatibility for PHP version and minor CI changes, i don't see a PR merged since may 2022. It may "come back to like", but i fear recent (and incoming) changes in Twig won't be implemented 🤷
I’m thinking that some documentation could help contributors here (perhaps I missed it).
Especially regarding the tools used in the CI that we don’t often see in Symfony repositories, such as PHPStan and TwigCS. Again, I may have missed something, but the Composer scripts do not seem to be designed with contributors in mind.
Maybe a simple “How to Contribute” section in the documentation or a dedicated CONTRIBUTING.md file would be beneficial?
Additionally, what about removing TwigCS and starting to use Twig-CS-Fixer by @VincentLanglet, which attentively follows all Twig changes and best practices TwigCS is officially EOL and, to my knowledge, has only added minimal support for new PHP releases in the last two years.
(These are just personal comments based on my experience this afternoon. Feel free to close this if I’m out of bounds.)
The text was updated successfully, but these errors were encountered: