Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Re-enable skipped legacy test #1630

Closed
smnandre opened this issue Dec 25, 2024 · 1 comment
Closed

[Tests] Re-enable skipped legacy test #1630

smnandre opened this issue Dec 25, 2024 · 1 comment

Comments

@smnandre
Copy link
Member

In MakeEntityTest, we can read the following lines

yield 'it_creates_a_new_class_and_api_resource' => [$this->createMakeEntityTest()
// @legacy - re-enable test when https://github.com/symfony/recipes/pull/1339 is merged
->skipTest('Waiting for https://github.com/symfony/recipes/pull/1339')
->addExtraDependencies('api')

Well, it has been merged :)

@smnandre
Copy link
Member Author

Well.... and a PR has already been opened (i really need to stop this habit of not checking open PR... 🤦 )

--> #1607

#sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant