Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:entity] generate() call to is_string() appears to always evaluate to false #1509

Open
jrushlow opened this issue Apr 5, 2024 · 1 comment
Labels
Bug Bug Fix

Comments

@jrushlow
Copy link
Collaborator

jrushlow commented Apr 5, 2024

if (\is_string($manipulatorOrMessage)) {

I believe $manipulatorOrMessage is always an instance of ClassSourceManipulator but I may be wrong. This could be an artifact leftover from previous versions where we did display a message. We need to confirm what use case would cause this not to be an instance of CSM.

For debugging:

  • change the conditional to $manipulatorOrMessage instanceOf ClassSourceManipulator -> getSourceCode() && exit early.
  • then attach breakpoint || dump($manipulatorOrMessage) in the else statement.
@jrushlow jrushlow added the Bug Bug Fix label Apr 5, 2024
@RazielRodrigues
Copy link

Hello @jrushlow I can work on this if nobody started :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix
Projects
None yet
Development

No branches or pull requests

2 participants