Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubyfication #62

Open
2 tasks
rajithv opened this issue Jul 21, 2016 · 2 comments
Open
2 tasks

Rubyfication #62

rajithv opened this issue Jul 21, 2016 · 2 comments

Comments

@rajithv
Copy link
Contributor

rajithv commented Jul 21, 2016

For better intuitiveness for Ruby users, some SymEngine constructs can be changed.

@zverok Let's add such instances to a list here.

  • Basic#to_proc instead of SymEngine::lambdify(basic)
  • Map SymEngine::Symbol to Ruby Symbols. ( x = SymEngine(:x) )
@zverok
Copy link
Collaborator

zverok commented Jul 21, 2016

About first, I still think the name should be to_proc.

lambdify could be an alias (for those knowing SymEngine better than Ruby), but for this case (matching Python API?..) it should be left as SymEngine::lambdify. So, what I propose here is:

  • leave SymEngine::lambdify but explicitly state that Basic#to_proc is preferred;
  • make Basic#to_proc to be able to do everything SymEngine::lambdify could do.

WDYT?

@rajithv
Copy link
Contributor Author

rajithv commented Jul 21, 2016

Yep. That's better. Updated the checklist to reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants