New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosine distance #71

Closed

mlesnoff opened this issue Mar 15, 2024 · 1 comment

mlesnoff commented Mar 15, 2024 •

edited

Loading

Is there not a typing error here?

BetaML.jl/src/Utils/Measures.jl

Lines 15 to 17 in 4bf2d55

    
           """Cosine distance""" 
        
           cosine_distance(x,y) = dot(x,y)/(norm(x)*norm(y)) 
        
           """

"""Cosine distance"""
cosine_distance(x,y) = dot(x,y)/(norm(x)*norm(y))
"""

I guess it should be:

"""Cosine distance"""
cosine_distance(x,y) = 1 - dot(x,y)/(norm(x)*norm(y))
"""

(if I well understood what you wanted to refer to as "cosine distance")

Owner

sylvaticus commented Mar 18, 2024

Thank you.

sylvaticus closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment