Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Clustering_MLJ caused by spelling mistake #65

Closed
ablaom opened this issue Jan 10, 2024 · 3 comments
Closed

Bug in Clustering_MLJ caused by spelling mistake #65

ablaom opened this issue Jan 10, 2024 · 3 comments

Comments

@ablaom
Copy link

ablaom commented Jan 10, 2024

Need fitesult -> fitresult in

MMI.fitted_params(model::Union{KMeans,KMedoids}, fitresult) = (centers=fitesult[2], cluster_labels=CategoricalArrays.categorical(fitresults[1]))

See also #64

@ablaom
Copy link
Author

ablaom commented Jan 10, 2024

Unless you already have them, can I suggest adding MLJ interface tests? See MLJTestInterface.jl and this example in MLJXGBoostInterface.jl tests. I expect these would pick these spelling mistakes up.

sylvaticus added a commit that referenced this issue Jan 11, 2024
@sylvaticus
Copy link
Owner

Unless you already have them, can I suggest adding MLJ interface tests? See MLJTestInterface.jl and this example in MLJXGBoostInterface.jl tests. I expect these would pick these spelling mistakes up.

Hi.. all BetaML - MLJ model interfaces have tests, however these are "manual" and focus on the various specific task of the model (classification, regression, etc...) in these cases the typo was on a one-line function (fitted_params) that isn't involved in the model main task and hence, my fault, outside of the test.

For new interfaces I will surely use the specific MLJ test framework..

@ablaom
Copy link
Author

ablaom commented Jan 14, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants