Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore org-journal to use the upstream package #16768

Open
lhernanz opened this issue Dec 30, 2024 · 0 comments
Open

Restore org-journal to use the upstream package #16768

lhernanz opened this issue Dec 30, 2024 · 0 comments

Comments

@lhernanz
Copy link

Emacs 29.4
Head of Spacemacs develop branch

Some calendar related functions (e.g. org-deadilne) are failing with org-9.7 as org-journal is creating an entry in a calendar hook that calls the method org-journal--with-journal. This method creates a buffer in fundamental mode with org contents that are parsed with the org-element api, generating a warning that makes the invocation to fail.

Long story short, Spacemacs is using a 3y old fork of org-journal that has not seen any updates since. Meanwhile upstream seems to be back to life after a period of low activity and they have fixed this particular bug and some others.

Although it does not seem that the changes that started the fork have been merged upstream, it seems that moving back to, better supported, upstream would be a wise move for Spacemance. If these changes are needed, upstream might be more willing to accept it that it was 3y ago.

Alternatively, I guess that @dalanicolai could update his fork with the latest changes from upstream so that he can preserve his changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant