Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): update styles of megadropdown #4350

Merged
merged 16 commits into from
Jan 22, 2025
Merged

fix(components): update styles of megadropdown #4350

merged 16 commits into from
Jan 22, 2025

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Dec 20, 2024

No description provided.

@leagrdv leagrdv requested review from a team as code owners December 20, 2024 14:06
@leagrdv leagrdv requested a review from alizedebray December 20, 2024 14:06
@leagrdv leagrdv linked an issue Dec 20, 2024 that may be closed by this pull request
Update megadropdown styles #4326
Closed
6 tasks
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f23de2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 20, 2024 •
edited
Loading

Related Previews

alizedebray
alizedebray requested changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@alizedebray alizedebray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On desktop the list titles that are not links are still missing an inline padding:
Screenshot 2024-12-31 at 15 02 29
  • On mobile the padding block on the list titles are incorrect and the arrow icon is too big on the links. Can you also check the heading font sizes?

packages/components/src/index.html Outdated Show resolved Hide resolved
@leagrdv leagrdv requested a review from alizedebray January 3, 2025 11:13
alizedebray
alizedebray requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the font-sizes and font-weights again please?
They are different on tablet and on mobile.

@leagrdv leagrdv requested a review from alizedebray January 22, 2025 13:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@leagrdv leagrdv merged commit c8b33b4 into main Jan 22, 2025
10 checks passed
@leagrdv leagrdv deleted the 4326-update-megadropdown-styles branch January 22, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alizedebray alizedebray alizedebray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update megadropdown styles
3 participants
@leagrdv @swisspost-bot @alizedebray