Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product card V2: Component or Module? #4174

Closed
sandra-post opened this issue Dec 6, 2024 · 2 comments
Closed

Product card V2: Component or Module? #4174

sandra-post opened this issue Dec 6, 2024 · 2 comments

Comments

@sandra-post
Copy link

Requirement / Request

We want to provide the UX designers with the product card for Design System V2.

➡️ Question for the Pattern Discussion

Is it a module (built with components from Design System, e.g. Card) and therefore needs to be created by Post Portal and OD teams, or is it a component and we create it in the Design System Foundations & Compos?

Resources

@sandra-post sandra-post added the needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. label Dec 6, 2024
@sandra-post
Copy link
Author

sandra-post commented Dec 10, 2024

We do not have defined "module" super-sharply. Roughly said, components and modules are distinguished and ordered in Figma based on the difference that a module consists of multiple components in comparison to a component.

The goal is, after all, that the user of the design system - the UX designer and the dev - finds what they are looking for as efficiently as possible. To find out how to structure the content, research needs to be done on how our users look for assets.

For the moment, since we have other priorities, and it does not have a significant impact whether an object is a component or a module, we add the product card as module to the design system. We can move it to components if change our opinion. The research about how to structure content can be done at a later point.

@sandra-post sandra-post removed the needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. label Dec 10, 2024
@sandra-post
Copy link
Author

Created #4377 [module]: Product card

@github-project-automation github-project-automation bot moved this from 👀 Triage to 🚀 Done in Design System Production Board Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Done
Development

No branches or pull requests

1 participant