Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the form-control-wrapper from several form docs #3164

Closed
oliverschuerch opened this issue Jun 20, 2024 · 1 comment · Fixed by #3166
Closed

Remove the form-control-wrapper from several form docs #3164

oliverschuerch opened this issue Jun 20, 2024 · 1 comment · Fixed by #3166
Assignees
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package

Comments

@oliverschuerch
Copy link
Contributor

The wrapper class was not implemented as specified (around the label, input and hint-text element) and should be removed for the following components:

  • input
  • select
  • textarea
  • slider
@oliverschuerch oliverschuerch added 🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package labels Jun 20, 2024
@github-project-automation github-project-automation bot moved this to 🗃️ Ready for work in Design System Production Board Jun 20, 2024
@oliverschuerch oliverschuerch self-assigned this Jun 20, 2024
@oliverschuerch oliverschuerch moved this from 🗃️ Ready for work to 🕹️ Dev in progress in Design System Production Board Jun 20, 2024
@oliverschuerch oliverschuerch moved this from 🕹️ Dev in progress to 🤬 Dev in code review in Design System Production Board Jun 20, 2024
@oliverschuerch
Copy link
Contributor Author

oliverschuerch commented Jun 27, 2024

@rouvenpost I changed the behaviour of the above mentioned form-control elements when validated and focused.
Please have a look at the following pages:

Set the Validation property to Valid or Invalid and focus the control afterwards to see, what I've done ;)

@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package
Projects
Development

Successfully merging a pull request may close this issue.

1 participant