This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Improve VersionManager to using with custom managers
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2018 00:05
**Problem** `VersionManager` is not friendly enough to custom manager, because of: 1. `get_queryset` always return `VersionedQuerySet`, as result it's impossible to override query set class throut `from_queryset` method; 1. `get_queryset` has some extra code which set `querytime` property for query set instance. As a result user should copy this two lines - this is not a pythonic way. **Solution** 1. Move `querytime`-code from `queryset` method into `querytime` decorator. 1. Some `VersionManager` methods use `VersionedQuerySet` methods, so we must ensure that they has deal with `VersionedQuerySet` or it's subclass. If not - we must warned user about potential problems.
|
Btw, why you add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
VersionManageris not friendly enough to custom manager, because of:get_querysetalways returnVersionedQuerySet, as result it's impossible to override query set class throutfrom_querysetmethod;get_querysethas some extra code which setquerytimeproperty for query set instance. As a result user should copy this two lines - this is not a pythonic way.Solution
querytime-code fromquerysetmethod intoquerytimedecorator.VersionManagermethods useVersionedQuerySetmethods, so we must ensure that they has deal withVersionedQuerySetor it's subclass. If not - we must warned user about potential problems.