Update a few things #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadoetsch
reviewed
Jan 21, 2024
There was a problem hiding this comment.
Looks goot to me.
@mrosskopf can you check the library author list? It is quite outdated and e.g. doesn't include Lion and you.
| { name = "Linus Villiger", email = "[email protected]" }, | ||
| { name = "Thomas Haag" }, | ||
| { name = "Sem Demir" }, | ||
| { name = "DUGSeis Authors" }, |
There was a problem hiding this comment.
This list of authors reflects a very early version of the library. Should this be changed to or extended with the authors of the current paper?
There was a problem hiding this comment.
@mrosskopf can you adjust the package author list?
| { name = "SCCER-SoE" }, | ||
| { name = "SED" }, | ||
| { name = "ETHZ" }, | ||
| { name = "Joseph Doetsch", email = "[email protected]" }, |
There was a problem hiding this comment.
My email can be removed (as it is also not valid anymore).
|
I integrated the changes manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.tomlbased package description.pyqtgraphrelated ones might need a deeper look.