Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover state to Hierarchy toggle background and hover + refactor #915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marinaaisa
Copy link
Member

Bug/issue #135891984, if applicable:

Summary

Add hover state to Hierarchy toggle background and border.

Color specs for the toggle in hover state:

  • Background: same background color as the Navigator's item hover
  • Border: figure-blue

Also, I realised that we still had color styles for the nav bar in dark mode that was no longer used since we moved the breadcrumbs into the Hero at #772, so I deleted those styles in a second commit.

Dependencies

NA

Testing

Steps:

  1. Go to any documentation page with many nested paths
  2. Assert that you see the toggle to open the nested routes
  3. Assert that the specs described above are correct

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Copy link
Contributor

@hqhhuang hqhhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the hover state color persists when the list is expanded but the mouse is off of the toggle. I would expect the hover background color to only be there when the mouse is actually hovering on the icon.
What do you think?

@marinaaisa
Copy link
Member Author

marinaaisa commented Nov 20, 2024

It seems like the hover state color persists when the list is expanded but the mouse is off of the toggle. I would expect the hover background color to only be there when the mouse is actually hovering on the icon. What do you think?

Yes, this is because I added the styles to the active state too. I modified it and now it only applies to hover states. Thanks for catching this up!

Copy link
Contributor

@hqhhuang hqhhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mportiz08
Copy link
Contributor

It looks like this only adds the hover state to the actual toggle and none of the links within the expanded menu when you hover over them after using that toggle. Should we also add something for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants