Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failfast as a config property #160

Closed
janderssonse opened this issue Oct 10, 2023 · 2 comments
Closed

Failfast as a config property #160

janderssonse opened this issue Oct 10, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@janderssonse
Copy link

janderssonse commented Oct 10, 2023

We would like to be able to set the failfast-property of the metadataprovider. Currently it is a bit buried, due to the provider being both created and intialized inside the create() method https://github.com/swedenconnect/signservice/blob/f5d49e265c52bd46c109d5d45f9ea5dcc3c90da7/authn/saml/src/main/java/se/swedenconnect/signservice/authn/saml/config/MetadataProviderConfiguration.java

A suggestion that would save us from implementing and overriding quite a few code snippets would be to make the property externally available as a config-boolean. Suggestion before the initialization method of the provider, example: provider.setFailFastInitialization(The-Boolean-from-config>);

@janderssonse janderssonse changed the title Failfast as an config property Failfast as a config property Oct 10, 2023
@janderssonse janderssonse added the enhancement New feature or request label Oct 10, 2023
@martin-lindstrom martin-lindstrom added this to the 1.1.0 milestone Oct 25, 2023
@martin-lindstrom
Copy link
Member

@janderssonse Will fix this in 1.1.0 (i.e., Java 17 version). OK?

@martin-lindstrom
Copy link
Member

Fixed in #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants