Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes suggested by Dimitrios #1054

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

martinosorb
Copy link
Contributor

@martinosorb martinosorb commented Nov 22, 2024

Fixes #1041, fixes #1045, fixes #1047, fixes #1044, issues raised by @astroDimitrios.

Additionally:

  • the wording "Add basic guacamole's ingredients" has been adjusted to "Add ingredients for basic guacamole"
  • a spurious lines has been removed from episode 5
  • a typo has been fixed in the discussion.

Copy link

github-actions bot commented Nov 22, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1054

The following changes were observed in the rendered markdown documents:

 04-changes.md | 13 ++++++-------
 05-history.md |  1 -
 06-ignore.md  |  8 ++++----
 discuss.md    |  4 ++--
 md5sum.txt    |  8 ++++----
 5 files changed, 16 insertions(+), 18 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-11-22 15:52:45 +0000

github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant