Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider giving require X and require n X different names to avoid confusion #2206

Open
byorgey opened this issue Nov 12, 2024 · 2 comments
Open

Comments

@byorgey
Copy link
Member

byorgey commented Nov 12, 2024

I am not surprised that require 0 "treads" did not work. require X and require n X, although they look similar, are quite distinct: the first requires a device to be equipped, and the second requires a certain number of copies of a device in the inventory. (I realize this is potentially confusing; open to suggestions for making the distinction more clear / easier to understand.)

Originally posted by @byorgey in #921 (comment)

Currently, require "boat" means you require a boat to be equipped, and require 5 "boat" means you require 5 boats in your inventory. Although superficially similar these are quite distinct commands, and in order to reduce confusion / help players remember what they mean, it might be worth renaming one or both of them.

@xsebek
Copy link
Member

xsebek commented Nov 21, 2024

How about:

  • stock 0 "threads" and equipped "threads"
  • requireEquipped 'boat' and requireAmount 5 'boat'
  • require 1 "threads"; equip "threads" and get rid of the auto-installation

@byorgey
Copy link
Member Author

byorgey commented Dec 3, 2024

I think I like stock for requiring stuff in the inventory. So maybe just stock for inventory vs require for equipped devices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants