Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Workplace users don't seem to be suspended #3161

Open
JobDoesburg opened this issue Jun 2, 2023 · 1 comment
Open

Google Workplace users don't seem to be suspended #3161

JobDoesburg opened this issue Jun 2, 2023 · 1 comment
Labels
app:activemembers Issues regarding the activemembers-app bug Something that should be fixed priority: medium A new feature or a bugfix that is non-critical.

Comments

@JobDoesburg
Copy link
Contributor

Describe the bug

Google Workplace users don't seem to be suspended.
For example, Sebastiaan Versteeg's account remained (I suspended it by hand to test things out). I have looked for some other people and they still all have accounts so I think it's just broken

How to reproduce

Yeah that's the thing

Expected behaviour

Properly remove accounts when people are no longer active anymore.

I think it would be good improve the logic a little bit: make a model in some app with a one-to-on field to a member, registering the fact that this person should have an account (or not), and possible a date that the account should be removed. Then the sync logic can at least be made more readable, more versatile and the sync can be made idempotent.

Screenshots

Additional context

@JobDoesburg JobDoesburg added priority: medium A new feature or a bugfix that is non-critical. bug Something that should be fixed labels Jun 2, 2023
@DeD1rk DeD1rk added this to the Release 52.0 milestone Nov 16, 2023
@DeD1rk
Copy link
Member

DeD1rk commented Jan 31, 2024

A simple solution without any new model/fields would be to just make a periodic task (similar to mailinglist sync) that compares the list of staff members with the gsuite accounts in members.thalia.nu, creates any missing accounts and suspends other accounts.

But then we do still have the updating (on username change) and deletion timing that is fragile. So the more complete solution would be to add a model with FK to user, the username on gsuite, and suspension timestamp. Then periodically:

  • Create gsuite account (and such a model) for each staff member that doesn't have one yet.
  • Update any account where the member__username doesnt match the gsuite username.
  • Suspend any account where the user is no longer staff (and set the suspension timestamp).
  • Delete any account that's been suspended for some time.

@DeD1rk DeD1rk added the app:activemembers Issues regarding the activemembers-app label Jan 31, 2024
@DeD1rk DeD1rk modified the milestones: Release 52.0, Release 53.0 Feb 6, 2024
@DeD1rk DeD1rk removed this from the Release 53.0 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:activemembers Issues regarding the activemembers-app bug Something that should be fixed priority: medium A new feature or a bugfix that is non-critical.
Projects
None yet
Development

No branches or pull requests

2 participants