Make SQS backend take an aws_sdk_sqs::Config instead of SdkConfig #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `aws_config::SdkConfig` is the base AWS configuration, and doesn't include any SQS-specific config options. We now allow users to pass in an `aws_sdk_sqs::Config` struct (which can be built from an `SdkConfig`), allowing SQS-specific options like timeouts and interceptors to be configured.
svix-aaron1011
force-pushed
the
aaron1011/sqs-config
branch
from
e5b8f40
to
851c2ed
Compare
svix-jplatte
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aws_config::SdkConfigis the base AWS configuration, and doesn't include any SQS-specific config options. We now allow users to pass in anaws_sdk_sqs::Configstruct (which can be built from anSdkConfig), allowing SQS-specific options like timeouts and interceptors to be configured.