Remove unnecessary &mut self
in SQS implementation
#84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to use the SQS implementation, I ran into papercuts with the consumer because
receive()
methods took self by mutable reference.These, uhh, don't need to do that. I realize the general Consumer traits takes a mutable reference because some underlying implementations require an immutable ref. But when calling the SQS Consumer methods directly, rather than through the consumer trait, this mutable reference is just annoying.
When I made this change, my linter started complaining about unbounded recursion from the macro definitions for implementing the consumer traits. Changing the macros to use the fully qualified struct syntax (e.g.
Struct::method
instead of&self.method
) seems to fix this?